Skip to content

fix(Icon): add testID prop #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arpitBhalla merged 2 commits into from
Jun 7, 2023
+8 −1
Merged

fix(Icon): add testID prop #3787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10e0fa8
Add overwritable testID to Icon
KrisLau May 11, 2023
396500d
Merge branch 'next' into next
arpitBhalla Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/base/src/Icon/Icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export type IconType =
| string;

export interface IconObject {
/** Test ID of icon. */
testID?: string;

/** Name of icon. */
name?: string;

Expand All @@ -58,6 +61,9 @@ export interface IconObject {
export type IconNode = boolean | React.ReactElement<{}> | Partial<IconProps>;

export interface IconProps extends InlinePressableProps, IconButtonProps {
/** Test ID of icon. */
testID?: string;

/** Type of icon set. [Supported sets here](#available-icon-sets). */
type?: IconType;

Expand Down Expand Up @@ -97,6 +103,7 @@ export interface IconProps extends InlinePressableProps, IconButtonProps {
/** Icons are visual indicators usually used to describe action or intent.
* They are also used for displaying information. */
export const Icon: RneFunctionComponent<IconProps> = ({
testID = 'RNE__ICON__CONTAINER',
type = 'material',
name,
size = 24,
Expand Down Expand Up @@ -146,6 +153,7 @@ export const Icon: RneFunctionComponent<IconProps> = ({

return (
<View
testID={testID}
style={StyleSheet.flatten([
!raised && styles.container,
(reverse || raised) && styles.button,
Expand All @@ -158,7 +166,6 @@ export const Icon: RneFunctionComponent<IconProps> = ({
: {},
containerStyle && containerStyle,
])}
testID="RNE__ICON__CONTAINER"
>
<Component
testID="RNE__ICON__CONTAINER_ACTION"
Expand Down