fix(CheckBox): reduce needless re-rendering of Icon#3773
Merged
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom Jun 7, 2023
Merged
fix(CheckBox): reduce needless re-rendering of Icon#3773arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
Conversation
✅ Deploy Preview for react-native-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CheckBoxIcon re-renders every time, even if nothing has changed. You can easily see this using a tool like https://github.com/welldone-software/why-did-you-render.
Type of change
How Has This Been Tested?
Checklist
yarn docs-build-apiAdditional context
In looking through this function, it seems that the
|| 24might not be necessary because the function already provides a default value of 24 forsize. But I left it alone in case it's meant to guard against users providing a zero forsize(as opposed to an undefined).