Skip to content

docs: add fontWeight for Text on android#3506

Merged
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
arpitBhalla:3042
May 6, 2022
Merged

docs: add fontWeight for Text on android#3506
arpitBhalla merged 2 commits intoreact-native-elements:nextfrom
arpitBhalla:3042

Conversation

@arpitBhalla
Copy link
Copy Markdown
Member

@arpitBhalla arpitBhalla commented May 6, 2022

Motivation

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@arpitBhalla arpitBhalla linked an issue May 6, 2022 that may be closed by this pull request
Update docs for: Text styles with themeprovider not working on Android. #3042
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #3506 (e9eaf6f) into next (fd0bbb6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #3506   +/-   ##
=======================================
  Coverage   79.49%   79.49%           
=======================================
  Files          87       87           
  Lines        1775     1775           
  Branches      772      772           
=======================================
  Hits         1411     1411           
  Misses        358      358           
  Partials        6        6
Impacted Files Coverage Δ
packages/base/src/Text/Text.tsx 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit f64b147 into react-native-elements:next May 6, 2022
@arpitBhalla arpitBhalla deleted the 3042 branch May 6, 2022 20:28
github-actions bot pushed a commit that referenced this pull request May 6, 2022
@arpitBhalla
docs: add fontWeight for Text on android (#3506)
20d9067
github-actions bot pushed a commit that referenced this pull request May 6, 2022
@arpitBhalla
docs: add fontWeight for Text on android (#3506)
1234ea4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Docs 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update docs for: Text styles with themeprovider not working on Android.

1 participant

@arpitBhalla