chore: migrate typealias to interface#3374
Merged
arpitBhalla merged 5 commits intoreact-native-elements:nextfrom Feb 26, 2022
Merged
chore: migrate typealias to interface#3374arpitBhalla merged 5 commits intoreact-native-elements:nextfrom
arpitBhalla merged 5 commits intoreact-native-elements:nextfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3374 +/- ##
=======================================
Coverage 78.88% 78.88%
=======================================
Files 89 89
Lines 1733 1733
Branches 761 761
=======================================
Hits 1367 1367
Misses 361 361
Partials 5 5
Continue to review full report at Codecov.
|
arpitBhalla
added a commit
that referenced
this pull request
Mar 17, 2022
arpitBhalla
added a commit
that referenced
this pull request
Mar 19, 2022
arpitBhalla
added a commit
that referenced
this pull request
Mar 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Type alias can't be merged, so revered back type to interface in Prop def