Skip to content

fix(ListItem): remove Accordion height animation#3352

Merged
arpitBhalla merged 1 commit intoreact-native-elements:nextfrom
arpitBhalla:accordion-fix
Feb 12, 2022
Merged

fix(ListItem): remove Accordion height animation#3352
arpitBhalla merged 1 commit intoreact-native-elements:nextfrom
arpitBhalla:accordion-fix

Conversation

@arpitBhalla
Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

@arpitBhalla arpitBhalla changed the title fix(ListItem): remove height animation fix(ListItem): remove Accordion height animation Feb 12, 2022
@arpitBhalla arpitBhalla added this to the v4.0.0 milestone Feb 12, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2022

Codecov Report

Merging #3352 (baee2cd) into next (29fe60b) will increase coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3352      +/-   ##
==========================================
+ Coverage   79.07%   79.25%   +0.18%     
==========================================
  Files          88       88              
  Lines        1701     1697       -4     
  Branches      744      740       -4     
==========================================
  Hits         1345     1345              
+ Misses        351      347       -4     
  Partials        5        5              
Impacted Files Coverage Δ
packages/base/src/ListItem/ListItem.Accordion.tsx 8.69% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29fe60b...baee2cd. Read the comment docs.

@arpitBhalla arpitBhalla merged commit 217f623 into react-native-elements:next Feb 12, 2022
@arpitBhalla arpitBhalla deleted the accordion-fix branch February 12, 2022 17:47
@arpitBhalla arpitBhalla linked an issue Feb 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Accordion animation prop do not work 'ListItem.Accordion' is something wrong with ScrollView ListItem.Accordion overlaps ListItem

1 participant