fix(AirbnbRating): add props to parent component#3335
Merged
arpitBhalla merged 4 commits intoreact-native-elements:nextfrom Feb 4, 2022
Merged
fix(AirbnbRating): add props to parent component#3335arpitBhalla merged 4 commits intoreact-native-elements:nextfrom
arpitBhalla merged 4 commits intoreact-native-elements:nextfrom
Conversation
arpitBhalla
requested changes
Feb 4, 2022
Member
arpitBhalla
left a comment
There was a problem hiding this comment.
You need to merge next first
Contributor
Author
|
Merged into |
Codecov Report
@@ Coverage Diff @@
## next #3335 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 88 88
Lines 1662 1662
Branches 731 731
=======================================
Hits 1329 1329
Misses 328 328
Partials 5 5
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
Co-authored-by: Arpit Bhalla <arpitbhalla2001@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
Co-authored-by: Arpit Bhalla <arpitbhalla2001@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
Co-authored-by: Arpit Bhalla <arpitbhalla2001@gmail.com>
arpitBhalla
added a commit
that referenced
this pull request
Mar 17, 2022
Co-authored-by: Arpit Bhalla <arpitbhalla2001@gmail.com>
arpitBhalla
added a commit
that referenced
this pull request
Mar 19, 2022
Co-authored-by: Arpit Bhalla <arpitbhalla2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix: Fixes the issue of props not being passed to module in the AirbnbRatings component
Did you add tests for your changes?
No. Please tell me how to write a test for this change, or if this change requires a test.
If relevant, did you update the documentation?
No, this change makes the component work in accordance with the documentation.
Summary
This change was made in response to issue #3289
with this change, the props are being passed correctly and the component works as expected.
Does this PR introduce a breaking change?
No.