Skip to content

feat(ThemeProvider)!: update withTheme and ThemeProvider#3324

Merged
arpitBhalla merged 29 commits intoreact-native-elements:nextfrom
arpitBhalla:perf-withTheme
Mar 27, 2022
Merged

feat(ThemeProvider)!: update withTheme and ThemeProvider#3324
arpitBhalla merged 29 commits intoreact-native-elements:nextfrom
arpitBhalla:perf-withTheme

Conversation

@arpitBhalla
Copy link
Copy Markdown
Member

@arpitBhalla arpitBhalla commented Jan 31, 2022

BREAKING CHANGE:

  • rename colors to lightColors in createTheme to distinguish theme.colors

Features

  • Add useMemo in ThemeProvider & makeStyles
  • Add useThemeMode hook

Fixes

  • Theme deepmerge Objects and Array

@arpitBhalla arpitBhalla linked an issue Jan 31, 2022 that may be closed by this pull request
@arpitBhalla arpitBhalla changed the title perf(themed): withTheme and ThemeProvider feat(ThemeProvider)!: update withTheme and ThemeProvider Mar 27, 2022
@react-native-elements react-native-elements deleted a comment from codecov bot Mar 27, 2022
@react-native-elements react-native-elements deleted a comment from codecov bot Mar 27, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2022

Codecov Report

Merging #3324 (72bf6a6) into next (4eb3961) will decrease coverage by 0.18%.
The diff coverage is 72.41%.

@@            Coverage Diff             @@
##             next    #3324      +/-   ##
==========================================
- Coverage   78.41%   78.22%   -0.19%     
==========================================
  Files          87       87              
  Lines        1751     1768      +17     
  Branches      772      780       +8     
==========================================
+ Hits         1373     1383      +10     
- Misses        373      380       +7     
  Partials        5        5              
Impacted Files Coverage Δ
packages/themed/src/config/withTheme.tsx 75.67% <44.44%> (-11.43%) ⬇️
packages/themed/src/config/makeStyles.ts 83.33% <71.42%> (-16.67%) ⬇️
packages/themed/src/config/ThemeProvider.tsx 87.50% <92.30%> (+2.88%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@arpitBhalla arpitBhalla merged commit fccd0d0 into react-native-elements:next Mar 27, 2022
@arpitBhalla arpitBhalla deleted the perf-withTheme branch March 27, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Closed or Merged 🏁

Development

Successfully merging this pull request may close these issues.

Improve makeStyles

1 participant