fixed unnecessary ThemProps in withTheme hoc - #2147

What are you trying to do? I'm not understanding what bug you're having

I think withTheme is an injector according this article https://medium.com/@jrwebdev/react-higher-order-component-patterns-in-typescript-42278f7590fb

const ThemedComponent = withTheme(Component)

theme updateTheme replaceTheme are already injected by withTheme should not be a required props of ThemedComponent, but currently the definition treat these as required props

That's not true. withTheme works as expected.

interface MyTextProps {
  name: string;
}

const MyText = withTheme<MyTextProps>(({ theme, name }) => (
  <Text style={{ color: theme.colors.primary }}>{name}</Text>
));

const Main = () => {
  return (
    <View style={styles.container}>
      <MyText name="Mary" />
    </View>
  );
};

Example without component props:

const MyText = withTheme(({ theme }) => (
  <Text style={{ color: theme.colors.primary }}>Mary</Text>
));

const Main = () => {
  return (
    <View style={styles.container}>
      <MyText />
    </View>
  );
};

Yes it works well in function component, but class component shows error

interface Props extends ThemeProps<any> {
  name: string
}

class MyText2 extends Component<Props> {
  public render() {
    const {
      name
      theme,
    } = this.props
    return (
      <Text style={{ color: theme.colors.primary }}>{name}</Text>
    )
  }
}

const ThemedMyText2 = withTheme(MyText2)

const Main2 = () => {
  return (
    <View style={styles.container}>
      <ThemedMyText2 name="Mary" />
    </View>
  );
}

Ahh okay, it'll fail because you didn't use the generic on withTheme. But I can still accept this 👍

Thanks again 💯

Live in 1.2.7

Thanks