Repository navigation
Conversation
Summary: Fixes an issue on Android where inline views/images are not correctly clipped when created within a Text parent. ### Root Cause ReactTextView is a plain View which cannot hold any child views, so ParagraphShadowNode disables `FormsStackingContext` for text. This means Fabric flatten's the paragraph's children, so any inline views become siblings of the text. This makes it impossible for inline views to be clipped by their parent Text. ### This PR Since PreparedTextView is recently being enabled by default and uses a ViewGroup which allows children, modify ParagraphShadowNode to re-enable `FormsStackingContext` if the flag is true. Changelog: [Android][Fixed] - Inline views and images are now clipped by a parent `<Text>` when prepared text layout is enabled Differential Revision: D127947575
|
@jasozh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127947575. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an issue on Android where inline views/images are not correctly clipped when created within a Text parent.
Root Cause
ReactTextView is a plain View which cannot hold any child views, so ParagraphShadowNode disables
FormsStackingContextfor text. This means Fabric flatten's the paragraph's children, so any inline views become siblings of the text. This makes it impossible for inline views to be clipped by their parent Text.This PR
Since PreparedTextView is recently being enabled by default and uses a ViewGroup which allows children, modify ParagraphShadowNode to re-enable
FormsStackingContextif the flag is true.Changelog: [Android][Fixed] - Inline views and images are now clipped by a parent
<Text>when prepared text layout is enabledDifferential Revision: D127947575