Skip to content

DevTools: Make the selected commit label editable - #21667

Closed
zhusiyi111 wants to merge 1 commit into
react:masterfrom
zhusiyi111:devtools-make-selected-commit-editable
Closed

zhusiyi111 wants to merge 1 commit into
react:masterfrom
zhusiyi111:devtools-make-selected-commit-editable

Conversation

@zhusiyi111

@zhusiyi111 zhusiyi111 commented Jun 12, 2021 •

Copy link
Copy Markdown

Make the selected commit label to be editable, so that developers can switch the commit index conveniently.

Here is the effect:
editable

@sizebot

sizebot commented Jun 12, 2021 •

Copy link
Copy Markdown

Comparing: 1a106bd...020a6f9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.89 kB 126.89 kB = 40.69 kB 40.69 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.70 kB 129.70 kB = 41.61 kB 41.61 kB
facebook-www/ReactDOM-prod.classic.js = 406.00 kB 406.00 kB = 75.07 kB 75.07 kB
facebook-www/ReactDOM-prod.modern.js = 394.35 kB 394.35 kB = 73.25 kB 73.25 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.00 kB 406.00 kB = 75.07 kB 75.07 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 020a6f9

@zhusiyi111
zhusiyi111 force-pushed the devtools-make-selected-commit-editable branch from 205294b to 020a6f9 Compare June 12, 2021 10:46
@zhusiyi111
zhusiyi111 marked this pull request as ready for review June 12, 2021 10:47
@zhusiyi111

Copy link
Copy Markdown
Author

@bvaughn Hi, what's your opinion about this PR?

@bvaughn

bvaughn commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

I think if we move forward with a feature like this, I'll go with #19957 since it was opened first. Thanks for understanding!

@bvaughn bvaughn closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants