fix(agents): resolve lib scripts via {skill-root}/lib - #4
Merged
Conversation
Consumer projects have no local lib/; bare bash lib/*.sh fails when
agents run from project CWD. Point status, capture, retro, and upgrade
invocations at {skill-root}/lib, and document the same contract in help.
Issue: ORI-238 UR: UR-003 Output: agents/config.md
Issue: ORI-238 UR: UR-003
Issue: ORI-239 UR: UR-003 Output: agents/run-worker.md
Issue: ORI-239 UR: UR-003
Issue: ORI-240
UR: UR-003
Output: agents/capture.md
Undo mechanical {skill-root} over-application: Files/footprint stay
project-relative lib/; upgrade identity prose uses lib/; missing-script
checks name resolved $SKILL_ROOT/lib/...; bash invoke keeps {skill-root}.
Co-authored-by: Tom Kaczocha <tomkaczocha@gmail.com>
Signed-off-by: Tom Kaczocha <tomkaczocha@gmail.com>
Issue: ORI-241 UR: UR-003 Output: references/run-loop.md
Issue: ORI-240 UR: UR-003
Issue: ORI-241 UR: UR-003
Issue: ORI-242 UR: UR-003 Output: lib/doc-lint.sh
Issue: ORI-242 UR: UR-003
Issue: ORI-237 UR: UR-003 Output: (verification-only; terminal state already on fix/skill-root-lib-paths)
Issue: ORI-237 UR: UR-003
Issue: ORI-244 UR: UR-004 Output: agents/config.md
Issue: ORI-244 UR: UR-004
Issue: ORI-245 UR: UR-004 Output: SKILL.md
Issue: ORI-245 UR: UR-004
Issue: ORI-246 UR: UR-004 Output: lib/doc-lint.sh Extend bare-runtime-bash-lib path-scope to SKILL.md so entry conformance cannot regress to bare bash lib/conformance-scan.sh. Keep skill-dev allowlist under agents/ and references/ only. Co-authored-by: Tom Kaczocha <tomkaczocha@gmail.com> Signed-off-by: Tom Kaczocha <tomkaczocha@gmail.com>
Issue: ORI-246 UR: UR-004
Issue: ORI-243 UR: UR-004 Output: (none — path-unit verify-only) Children ORI-244/245/246 already land walk-up resolve, SKILL.md entry skill-root before conformance, and doc-lint SKILL.md guard. Terminal state verified on fix/skill-root-lib-paths; zero diffs. Co-authored-by: Tom Kaczocha <tomkaczocha@gmail.com> Signed-off-by: Tom Kaczocha <tomkaczocha@gmail.com>
Issue: ORI-243 UR: UR-004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash lib/*.shinvocations at{skill-root}/lib/so scripts resolve from the skill install path, not the consumer project CWD.status,capture,retro, andupgrade; adds a skill-root note tohelpfor optional lib helpers.Test plan
lib/, run/do-work statusand confirm synth-status / derive-status / coverage-rollup / deadlock-check resolve./do-work capturepath that hits cycle-check and confirm{skill-root}/lib/cycle-check.shis used./do-work retroand confirm retro-rollup path./do-work upgradedetectors that shell out to conformance-scan / install-hooks./do-workhelp still caps at 4 suggestions and documents skill-root for lib helpers.