[SW-562] update unit test skipif condition for mac-related issues#102
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 24 24
Lines 5132 5132
=======================================
Hits 3881 3881
Misses 1251 1251 ☔ View full report in Codecov by Sentry. |
Contributor
|
I don't know that we want to remove Mac \w 3.7-3.10 from running any unit tests. Just the ones with |
e222a7a to
5c387f7
Compare
5c387f7 to
1918b79
Compare
Contributor
Author
@amessing-bdai updated the code and the PR description (with traces from latest build-test workflow). could you please take another look? thanks! |
amessing-bdai
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update several unit tests'
skipifconditions, as a follow-up to #96Some example traces taken from the build-test workflow for this PR:
tests/base/test_graphics.py .............tests/base/test_graphics.py sssssssssssss