Fix compiler warning: zero-initialize tm struct in DateTime::getTmUtc() - #754
Open
peremunoz wants to merge 1 commit into
Open
Fix compiler warning: zero-initialize tm struct in DateTime::getTmUtc()#754peremunoz wants to merge 1 commit into
peremunoz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were made
Replaced
tm result = {0};with value-initializationtm result = {};inFIX::DateTime::getTmUtc()insidesrc/C++/FieldTypes.h.Why the changes were necessary
Compiling QuickFIX with compiler warnings enabled (
-Wextra/-Wall) triggers a-Wmissing-field-initializerswarning onstruct tm:Using
{0}only explicitly initializes the first struct member (tm_sec), causing GCC/Clang to warn about missing initializers for POSIX extension members (such astm_gmtoffandtm_zone).Updating to
tm result = {};performs standard C++ value-initialization across all fields ofstruct tmwithout triggering-Wmissing-field-initializerswarnings.Related Issues
Fixes #753