Fix LocalFree leak in error_wsaerror - #749
Open
ManiSalahmand wants to merge 1 commit into
Open
Conversation
- release the buffer allocated by `FormatMessageA` using an exception-safe scope guard - check both the formatting result and buffer before appending message text - preserve existing successful WSA error output - return a deterministic wrapper-only string when formatting fails - add a focused Windows-only failure-path assertion - Linux Release configure and build passed - clang-format and git diff checks passed - non-network UtilityTests passed - full Linux unit run reached 1,955 passing assertions; eight socket assertions were blocked by sandbox network restrictions - Windows-specific behavior remains to be validated by CI Fixes quickfix#555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormatMessageAusing an exception-safe scope guardTesting
Fixes #555