Fix buffer overrun in ThreadedSocketConnection partial sends - #742
Open
PauloHMattos wants to merge 1 commit into
Open
Fix buffer overrun in ThreadedSocketConnection partial sends#742PauloHMattos wants to merge 1 commit into
PauloHMattos wants to merge 1 commit into
Conversation
The `send` method in `ThreadedSocketConnection` incorrectly passed the total message length to `socket_send` on every iteration of the loop. In the event of a partial send, advancing the buffer pointer while keeping the size argument as the total message length caused the socket to read past the end of the allocated string buffer. Updated the `socket_send` size argument to calculate the remaining length (`msg.length() - totalSent`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sendmethod inThreadedSocketConnectionincorrectly passed the total message length tosocket_sendon every iteration of the loop. In the event of a partial send, advancing the buffer pointer while keeping the size argument as the total message length caused the socket to read past the end of the allocated string buffer.Updated the
socket_sendsize argument to calculate the remaining length (msg.length() - totalSent).