Skip to content

Fix IDE hint channels_last & preserve_format - #39120

Closed
Kiyosora wants to merge 2 commits into
pytorch:masterfrom
Kiyosora:add_IDE_hint
Closed

Kiyosora wants to merge 2 commits into
pytorch:masterfrom
Kiyosora:add_IDE_hint

Conversation

@Kiyosora

@Kiyosora Kiyosora commented May 28, 2020 •

Copy link
Copy Markdown
Contributor

@Kiyosora
Kiyosora marked this pull request as ready for review May 28, 2020 01:31
@dr-ci

dr-ci Bot commented May 28, 2020 •

Copy link
Copy Markdown

💊 CI failures summary and remediations

As of commit 6a373f1 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@gchanan
gchanan requested a review from VitalyFedyunin June 1, 2020 02:06
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 1, 2020
@Kiyosora

Kiyosora commented Jun 5, 2020

Copy link
Copy Markdown
Contributor Author

Since this PR has been around for a while, is there anyone who'd like to review this PR?
@ezyang @VitalyFedyunin

@facebook-github-bot facebook-github-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@ezyang merged this pull request in 51504cb.

@Kiyosora
Kiyosora deleted the add_IDE_hint branch June 5, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants