Repository navigation
Conversation
…save overhead [ghstack-poisoned]
…dingBag to save overhead" [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 8b3c877 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 6 times. |
…dingBag to save overhead" Differential Revision: [D21058006](https://our.internmc.facebook.com/intern/diff/D21058006) [ghstack-poisoned]
Member
|
Hi @jamesr66a could you take a quick look at this? It looks good to me. Thanks! |
…dingBag to save overhead" Differential Revision: [D21058006](https://our.internmc.facebook.com/intern/diff/D21058006) [ghstack-poisoned]
bharatr21
pushed a commit
to bharatr21/pytorch
that referenced
this pull request
May 5, 2020
…save overhead (pytorch#36681) Summary: Pull Request resolved: pytorch#36681 Test Plan: Imported from OSS Unit tests: python test/run_test.py -i test_nn -- TestNNDeviceTypeCPU.test_EmbeddingBag_per_sample_weights_failures_cpu python test/run_test.py -i test_nn -- TestNNDeviceTypeCPU.test_EmbeddingBag_per_sample_weights_and_offsets_cpu python test/run_test.py -i test_nn -- TestNNDeviceTypeCPU.test_EmbeddingBag_per_sample_weights_and_new_offsets_cpu python test/run_test.py -i test_nn -- TestNNDeviceTypeCPU.test_EmbeddingBag_per_sample_weights_and_no_offsets_cpu python test/test_nn.py TestNN.test_embeddingbag_from_pretrained python test/test_nn.py TestNN.test_embeddingbag_from_pretrained_options Finally run: python test/test_nn.py Reviewed By: jspark1105 Differential Revision: D21058006 Pulled By: xing-liu fbshipit-source-id: 65b36a788839e8b722db3e295e58215b5935d6e8
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21058006