Repository navigation
Conversation
💊 CircleCI build failures summary and remediationsAs of commit ed8a018 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following build failures do not appear to be due to upstream breakages:
|
| Job | Step | Status |
|---|---|---|
| Build | ||
| Checkout pytorch/builder repo | ||
| Checkout pytorch/builder repo | ||
| Build |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker.
This comment has been revised 12 times.
VitalyFedyunin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please add tests.
Collaborator
Author
|
@VitalyFedyunin Thanks for the comment. I have added tests. |
Collaborator
|
@VitalyFedyunin @xwang233 unfortunately tests like this tend to be flaky, we already had to disable a similar one (because there's no guarantee that python interpreter will be fast enough to query the stream while the stream has work), and also unfortunately there's no robust way to write a test for this behavior, so I suggest merging this PR w/o a test. |
Collaborator
Author
|
@ngimel @VitalyFedyunin Thanks for the comments. I skipped the test, and kept the test code. People can refer to the test code and test it locally. |
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ngimel
approved these changes
Mar 23, 2020
Contributor
xwang233
added a commit
to xwang233/pytorch
that referenced
this pull request
Mar 25, 2020
gchanan
pushed a commit
that referenced
this pull request
Mar 25, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 29, 2020
…46878) Summary: Fixes #39694. [`torch.cuda._sleep(int(100 * get_cycles_per_ms()))`](https://github.com/pytorch/pytorch/pull/46878/files#diff-893b1eea27352f336f4cd832919e48d721e4e90186e63400b8596db6b82e7450R511-R513) in the test helps avoid flakiness noted by ngimel (#35144 (comment)). Pull Request resolved: #46878 Reviewed By: izdeby Differential Revision: D24550403 Pulled By: xw285cornell fbshipit-source-id: 1ecc35ef75f9a38ab332aacdf4835955105edafc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code
will be blocked in the current master, and will not be blocked in pytorch 1.4 release. This can be verified by a
nvprof --print-api-trace python script.pyprofiling. It is causing performance issue.I isolated the problem, and @jjsjann123 & @ptrblck pointed out the fix. Thanks!
cc @csarofeen @ptrblck @jjsjann123 @VitalyFedyunin @ngimel