🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/179750

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• Rolling out OSDC (ARC) runners on pull & trunk workflows in PyTorch main

❌ 3 Awaiting Approval, 1 Cancelled Job, 1 Unrelated Failure

As of commit f11490c with merge base 781bb5c ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorchbot label "topic: not user facing"

To add the ciflow label ciflow/h100 please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorchmergebot label ciflow/h100 ciflow/b200

@eqy can you rerun the CI , I added another push to fix lint and it got canceled.

@pytorchmergebot ciflow/h100 ciflow/b200

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'ciflow/h100' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'lint', 'fix-lint', 'apply-lint', 'cherry-pick')

usage: @pytorchbot [-h]
                   
                   {merge,revert,rebase,label,drci,lint,fix-lint,apply-lint,cherry-pick}
                   ...

Try @pytorchbot --help for more info.

@pytorchmergebot label ciflow/h100 ciflow/b200

@eqy can you please review it, failing test is timeout and not due to my change. Thanks.

@eqy @ngimel can someone please review this, thanks.

@eqy PR is ready to be reviews, removed some more complexity around test and code. Thanks for pointing it out.

@eqy PR is ready to be reviewed again.

@eqy added test update to check for tf32.

@eqy can we merge this. Thanks

Can someone provide a tl;dr of what's going on with precision settings - I see constant issues about it, warnings warn about nonexistent things, settings don't work, but I don't have a full picture, and I don't understand which part of the full picture (if any) this PR is fixing

Can someone provide a tl;dr of what's going on with precision settings - I see constant issues about it, warnings warn about nonexistent things, settings don't work, but I don't have a full picture, and I don't understand which part of the full picture (if any) this PR is fixing

@ngimel I can give you tldr, basically when we set torch.backends.fp32_precision =ieee, it should set for conv/rnn too , but they were not being set, only cunn, matmul were set automatically.

@malfet @eqy I have rebased it, hope tests pass and we can merge this soon. Thanks

@malfet @eqy I dont think failures are due to my change, can we merge this ?

@ngimel this PR is hopefully orthogonal to user complaints about warning spam with fp32 precision settings
I think the most egregious warning was already removed some time ago #166956 but still receives (loud) complaints from the community members who are on a older release

I'm trying to migrate some of the remaining uses over soon (tm) #180230

@pytorchmergebot rebase

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Successfully rebased fp32_invokeAll onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fp32_invokeAll && git pull --rebase)