Skip to content

Normalized lead email with migration#2123

Merged
renzon merged 2 commits into
masterfrom
2122
Mar 6, 2020
Merged

Normalized lead email with migration#2123
renzon merged 2 commits into
masterfrom
2122

Conversation

@renzon

@renzon renzon commented Mar 6, 2020

Copy link
Copy Markdown
Member

close #2122

@codecov

codecov Bot commented Mar 6, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2123 into master will increase coverage by 0.05%.
The diff coverage is 89.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
+ Coverage   95.33%   95.39%   +0.05%     
==========================================
  Files         170      172       +2     
  Lines        5123     5187      +64     
==========================================
+ Hits         4884     4948      +64     
  Misses        239      239              
Impacted Files Coverage Δ
pythonpro/payments/views.py 91.85% <0.00%> (ø)
pythonpro/core/tests/test_lead_email_migration.py 100.00% <0.00%> (ø)
...pro/core/migrations/0011_normalizing_lead_email.py 96.55% <0.00%> (ø)
pythonpro/core/admin.py 48.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5657606...0689db6. Read the comment docs.

@renzon renzon merged commit 26b75b7 into master Mar 6, 2020
@renzon renzon deleted the 2122 branch March 6, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Lead emails to lower case

1 participant