Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ wheels/
*.egg-info/
.installed.cfg
*.egg
dumps/

# PyInstaller
# Usually these files are written by a python script from a template
Expand Down
1 change: 1 addition & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ pytest-django = "*"
pytest-freezegun = "*"
pytest-mock = "*"
pytest = "*"
django-test-migrations = "*"

[requires]
python_version = "3.8"
74 changes: 41 additions & 33 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions pythonpro/core/migrations/0010_normalizing_email.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Generated by Django 3.0.3 on 2020-02-28 11:30

from django.db import IntegrityError, migrations

from django.db.transaction import atomic


def normalize_email(apps, schema_editor):
'''
We can't import the Post model directly as it may be a newer
version than this migration expects. We use the historical version.
'''
User = apps.get_model('core', 'User')
print()
for msg in normalize_all_users_email(User):
print(msg)


def normalize_all_users_email(User):
for user in User.objects.order_by('id').all():
original_email = user.email
normalized_email = user.email.lower()
if normalized_email != original_email:
user.email = normalized_email
try:
with atomic():
user.save()
except IntegrityError:
yield f'Normalization error user {user.id}, {original_email}'


class Migration(migrations.Migration):
dependencies = [
('core', '0009_auto_20191031_1324'),
]

operations = [
migrations.RunPython(normalize_email, migrations.RunPython.noop)
]
32 changes: 32 additions & 0 deletions pythonpro/core/tests/test_email_migration.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
from importlib import import_module

from model_mommy import mommy

# Workaround since module beginning with number can't be imported in regular way
migration_module = import_module('pythonpro.core.migrations.0010_normalizing_email')


def test_user_email_normalization_success(django_user_model):
"""Ensures email can be normalized"""

upper_email = 'UPPER@python.pro.br'
mommy.make(django_user_model, email=upper_email)
msg = next(migration_module.normalize_all_users_email(django_user_model), None)
assert msg is None
assert django_user_model.objects.first().email == upper_email.lower()


def test_no_msg_for_already_normalized_emails(django_user_model):
mommy.make(django_user_model, email='lower@python.pro.br')
msg = next(migration_module.normalize_all_users_email(django_user_model), None)
assert msg is None


def test_conflictiong_email_msg(django_user_model):
lower_email = 'normalized@python.pro.br'
upper_email = 'NORMALIZED@python.pro.br'
upper_email_user = mommy.make(django_user_model, email=upper_email)
mommy.make(django_user_model, email=lower_email)
msg = next(migration_module.normalize_all_users_email(django_user_model))
upper_email_user = django_user_model.objects.get(id=upper_email_user.id)
assert msg == f'Normalization error user {upper_email_user.id}, {upper_email_user.email}'