Skip to content

Improve method binding #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koubaa wants to merge 11 commits into from
Closed

Improve method binding #974

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
21528ee
Add test for ienumerable method
koubaa Oct 21, 2019
b4d60c6
Add tests for collection & task/action from function
koubaa Dec 1, 2019
3f02abf
Add more tests
koubaa Dec 1, 2019
9c3e1c5
Implement list converter
koubaa Dec 1, 2019
b9db0f6
Implement action converter
koubaa Dec 1, 2019
4b0a1ad
add TODO
koubaa Dec 1, 2019
8bed1bb
Update changelog
koubaa Dec 1, 2019
a4599d9
share common code between ToArray and ToList
koubaa Dec 2, 2019
96fd896
improve ref counting
koubaa Dec 3, 2019
c6fd768
revert whitespace
koubaa Dec 4, 2019
e63d11e
list wrapper
koubaa Dec 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve ref counting
  • Loading branch information
@koubaa
koubaa committed Dec 3, 2019
commit 96fd89692a7ce74213e08fa6e70163f1dcc4530d
8 changes: 2 additions & 6 deletions src/runtime/converter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,22 +941,18 @@ private static bool ToAction(IntPtr value, Type obType, out object result, bool
if (setError) {
SetConversionError(value, obType);
}
obj.Dispose();
return false;
}

Action action = () => {
PyObject py_action = new PyObject(value);
var py_args = new PyObject[0];
var py_result = py_action.Invoke(py_args);

//Discard the result since this is being converted to an Action
py_result.Dispose();
py_action.Dispose();
Runtime.XDecref(value);
};
Comment on lines +948 to +962
Copy link
Copy Markdown
Member

@lostmsu lostmsu Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object pointed to by value can be collected between the construction of this action, and the moment it is invoked. It would lead to a memory corruption.

Copy link
Copy Markdown
Contributor Author

@koubaa koubaa Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten to push the latest change set, please check again


Runtime.XIncref(value);
result = action;
obj.Dispose();
return true;
}

Expand Down