Repository navigation
Adds support to convert iterators to arrays - #928
Conversation
0bd4a10 to
2e51321
Compare
|
This looks like a good addition feature-wise, but there is quite a bit of duplicated code in it. I think it would be better if we had /one/ implementation based on the iterator protocol, that just uses an additional size hint if |
Sure. Presumably sequence protocol => iterator protocol? |
|
It says so in the docs: https://docs.python.org/2/library/stdtypes.html#iterator-types as well as https://docs.python.org/3/library/stdtypes.html#iterator-types:
|
1a23917 to
933bf0e
Compare
933bf0e to
c7be482
Compare
Ok, have redone - always uses iterator protocol now. |
|
@filmor Passed! |
|
This looks great, thanks :) |
What does this implement/fix? Explain your changes.
Python 3 has much more liberal use of iterators, e.g. getting keys or values from a dictionary. This adds functionality to convert python object which support the iterator protocol to arrays in C#.
Does this close any currently open issues?
No
Any other comments?
N/A
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG