Skip to content

Removes imports deprecated in Python3 - #925

Merged
filmor merged 2 commits into
pythonnet:masterfrom
Cronan:py3_fix
Aug 2, 2019
Merged

Removes imports deprecated in Python3#925
filmor merged 2 commits into
pythonnet:masterfrom
Cronan:py3_fix

Conversation

@Cronan

@Cronan Cronan commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

A small number of existing imports are deprecated in Python3.
This removes them or compiles them out.

Does this close any currently open issues?

Fixes #924
...

Any other comments?

N/A

Checklist

Check all those that are applicable and complete.

  • [N/A] Make sure to include one or more tests for your change
  • [N/A] If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@Cronan
Cronan marked this pull request as ready for review July 30, 2019 15:09
@Cronan

Cronan commented Jul 31, 2019

Copy link
Copy Markdown
Contributor Author

@filmor Any idea why the build is broken?

@filmor

filmor commented Jul 31, 2019

Copy link
Copy Markdown
Member

The Appveyor build just timed out for one part, I triggered it again and it seems to work fine now. The Travis build looks a bit trickier, the Mono version pulled in seems to be broken...

@filmor

filmor commented Jul 31, 2019

Copy link
Copy Markdown
Member

Meh, the travis error is broken. The symbol it is missing is _ZTIPi which is the C++ type info for int*, so maybe there are incompatible C++ ABIs at play here ...

@Cronan

Cronan commented Aug 1, 2019

Copy link
Copy Markdown
Contributor Author

How can the build just break? Were there changes made?

@filmor

filmor commented Aug 1, 2019

Copy link
Copy Markdown
Member

The mono version is not pinned right now, so since the 18th we pull in mono 6. I'll see whether I can lock us to 5.20 for now.

@Cronan

Cronan commented Aug 1, 2019 via email

Copy link
Copy Markdown
Contributor Author

@filmor filmor mentioned this pull request Aug 1, 2019
Merged
@codecov-io

codecov-io commented Aug 1, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #925 into master will increase coverage by 1.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   74.48%   76.25%   +1.76%     
==========================================
  Files          62       65       +3     
  Lines        5902     6030     +128     
  Branches      967      990      +23     
==========================================
+ Hits         4396     4598     +202     
+ Misses       1153     1099      -54     
+ Partials      353      333      -20
Flag Coverage Δ
#setup_linux 65.44% <ø> (ø) ⬆️
#setup_windows 75.48% <ø> (+1.97%) ⬆️
Impacted Files Coverage Δ
src/runtime/runtime.cs 86.95% <ø> (+0.01%) ⬆️
src/runtime/interop.cs 95.73% <0%> (-0.49%) ⬇️
src/runtime/interop35.cs 100% <0%> (ø)
src/runtime/interop37.cs 100% <0%> (ø)
src/runtime/interop36.cs 100% <0%> (ø)
src/runtime/typemanager.cs 83.64% <0%> (+0.25%) ⬆️
src/runtime/moduleobject.cs 81.31% <0%> (+0.54%) ⬆️
src/runtime/exceptions.cs 79.13% <0%> (+1.45%) ⬆️
src/runtime/assemblymanager.cs 87.03% <0%> (+1.85%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f635a4...f6a9954. Read the comment docs.

@Cronan

Cronan commented Aug 2, 2019

Copy link
Copy Markdown
Contributor Author

@filmor Can be merged?

@filmor

filmor commented Aug 2, 2019

Copy link
Copy Markdown
Member

Yeah, looks good to me. @lostmsu Be aware of this one if you are looking into switching to delegates.

@filmor
filmor merged commit 1ce630e into pythonnet:master Aug 2, 2019
@jj-tetraquark jj-tetraquark mentioned this pull request Aug 13, 2019
Closed
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 18, 2020
@Cronan @AlexCatarino
Removes imports deprecated in Python3 (pythonnet#925)
ae18126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python2 deprecated native method import

3 participants

@Cronan @filmor @codecov-io