Skip to content

Provide hook to implement __repr__ #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 17 commits into from
Oct 18, 2019
Merged

Provide hook to implement __repr__ #808

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
351d9ff
Provide hook to implement __repr__
koubaa Jan 20, 2019
d71a391
Merge branch 'master' into repr
filmor Mar 6, 2019
2a002d7
fix casing
koubaa Mar 8, 2019
cf1f1dc
Merge branch 'master' into repr
filmor Mar 19, 2019
1c0984f
Merge branch 'master' into repr
koubaa Apr 5, 2019
a5b245b
Merge branch 'master' into repr
filmor Apr 7, 2019
82aea1f
Merge branch 'master' into repr
filmor Apr 8, 2019
502f0c3
Merge branch 'master' into repr
filmor Jun 20, 2019
eb4004a
Merge branch 'master' into repr
filmor Aug 2, 2019
c6ae6a4
Merge branch 'master' into repr
filmor Sep 12, 2019
0916406
update based on review
koubaa Sep 15, 2019
2fb6a43
fix whitespace
koubaa Sep 15, 2019
9fc5b5f
fix whitespace
koubaa Sep 15, 2019
00b55db
fix
koubaa Sep 15, 2019
accc797
Don't use repr in __str__. Clean up unneeded tests
koubaa Oct 16, 2019
ff5d96c
fix leak
koubaa Oct 16, 2019
264c78b
Merge branch 'master' into repr
koubaa Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix leak
  • Loading branch information
@koubaa
koubaa committed Oct 16, 2019
commit ff5d96c1c888f6f432689ecfe9190473955eb7c7
5 changes: 4 additions & 1 deletion src/runtime/classbase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,10 @@ public static IntPtr tp_repr(IntPtr ob)
IntPtr args = Runtime.PyTuple_New(1);
Runtime.PyTuple_SetItem(args, 0, ob);
IntPtr reprFunc = Runtime.PyObject_GetAttrString(Runtime.PyBaseObjectType, "__repr__");
return Runtime.PyObject_Call(reprFunc, args, IntPtr.Zero);
var output = Runtime.PyObject_Call(reprFunc, args, IntPtr.Zero);
Runtime.XDecref(args);
Copy link
Copy Markdown
Contributor

@DanBarzilian DanBarzilian Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decreasing args reference count actually decreases ob reference count, which marks it as garbage for the GC!
After a while GC frees the object which causes the program to crash if the object is used again.
One fix for this can be adding the line:
Runtime.XIncref(ob);
at line 269 (before setting ob to the tuple's first argument).

Copy link
Copy Markdown
Member

@filmor filmor Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for catching this. Would you prepare a small PR?

Copy link
Copy Markdown
Contributor

@DanBarzilian DanBarzilian Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
1160

Runtime.XDecref(reprFunc);
return output;
}
catch (Exception e)
{
Expand Down