Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
All finalizers are disabled until valid implementation. Helps to avoi…
…d non relevant CI build faults.
  • Loading branch information
dse committed Sep 4, 2017
commit 085239291e53e6952e6a5ccf90358e71c1fa6220
4 changes: 4 additions & 0 deletions src/runtime/delegatemanager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ public Dispatcher(IntPtr target, Type dtype)

~Dispatcher()
{
// We needs to disable Finalizers until it's valid implementation.
// Current implementation can produce low probability floating bugs.
return;

// Note: the managed GC thread can run and try to free one of
// these *after* the Python runtime has been finalized!
if (Runtime.Py_IsInitialized() > 0)
Expand Down
6 changes: 5 additions & 1 deletion src/runtime/pyobject.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections;
using System.Dynamic;
using System.Linq.Expressions;
Expand Down Expand Up @@ -43,6 +43,10 @@ protected PyObject()

~PyObject()
{
// We needs to disable Finalizers until it's valid implementation.
// Current implementation can produce low probability floating bugs.
return;

Dispose();
}

Expand Down
6 changes: 5 additions & 1 deletion src/runtime/pyscope.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Linq;
using System.Collections.Generic;
using System.Dynamic;
Expand Down Expand Up @@ -527,6 +527,10 @@ public void Dispose()

~PyScope()
{
// We needs to disable Finalizers until it's valid implementation.
// Current implementation can produce low probability floating bugs.
return;

Dispose();
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/runtime/pythonexception.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ public PythonException()

~PythonException()
{
// We needs to disable Finalizers until it's valid implementation.
// Current implementation can produce low probability floating bugs.
return;

Dispose();
}

Expand Down