Skip to content

Work around a broken shared detection on some platforms #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
den-run-ai merged 6 commits into from
Dec 7, 2016
Merged

Work around a broken shared detection on some platforms #300

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
64dba41
Update setup.py
Dec 4, 2016
c17f38f
Update setup.py
Dec 7, 2016
c86ba2f
Update setup.py
Dec 7, 2016
a1d5849
Update setup.py
Dec 7, 2016
bd07eb0
Update .travis.yml
Dec 7, 2016
a5f7b5a
Small cleanup.
filmor Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,14 @@ def build_extension(self, ext):
defines.append("MONO_OSX")
else:
defines.append("MONO_LINUX")

# Check if --enable-shared was set when Python was built
enable_shared = get_config_var("Py_ENABLE_SHARED")
Copy link
Copy Markdown

@mikofski mikofski Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital "y" as in PY_ENABLE_SHARED?

Copy link
Copy Markdown
Contributor Author

@den-run-ai den-run-ai Dec 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/search?utf8=%E2%9C%93&q=Py_ENABLE_SHARED

if enable_shared == 1:
# Double-check if libpython is linked dynamically with python
lddout = check_output(["ldd", sys.executable])
if 'libpython' not in lddout:
enable_shared = 0
if enable_shared == 0:
defines.append("PYTHON_WITHOUT_ENABLE_SHARED")

Expand Down