Skip to content

Py3 comparison operators #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArvidJB wants to merge 9 commits into from
Closed

Py3 comparison operators #291

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
68e81c7
Do not call Decref if self.repr is still IntPtr.Zero
Oct 19, 2016
60c5a96
Same self.repr null check in ConstructorBinding.tp_dealloc
Oct 20, 2016
81958b2
Rename Runtime.Incref/Decref to XIncref/XDecref to signal that they c…
Oct 27, 2016
1445a79
Add missing changes for Python 2
Oct 27, 2016
c40d859
Implement comparison operations
Nov 16, 2016
649fcbd
Merge branch 'master' into py3_compare
ArvidJB Nov 16, 2016
81e9d61
Disable tests for Python 2
Nov 16, 2016
233b2da
Merge remote-tracking branch 'ArvidJB_pythonnet/py3_compare' into py3…
Nov 16, 2016
4b5ae6d
Merge branch 'master' into py3_compare
ArvidJB Nov 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable tests for Python 2
  • Loading branch information
abessen committed Nov 16, 2016
commit 81e9d61a112feb02145a5f7ffc43f92968b917a0
45 changes: 25 additions & 20 deletions src/tests/test_class.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,34 +210,39 @@ def testComparisons(self):
self.assertEqual(d1 == d2, False)
self.assertEqual(d1 != d2, True)

self.assertEqual(d1 < d2, True)
self.assertEqual(d1 <= d2, True)
self.assertEqual(d1 >= d2, False)
self.assertEqual(d1 > d2, False)
if six.PY3:
self.assertEqual(d1 < d2, True)
self.assertEqual(d1 <= d2, True)
self.assertEqual(d1 >= d2, False)
self.assertEqual(d1 > d2, False)

self.assertEqual(d1 == d1, True)
self.assertEqual(d1 != d1, False)

self.assertEqual(d1 < d1, False)
self.assertEqual(d1 <= d1, True)
self.assertEqual(d1 >= d1, True)
self.assertEqual(d1 > d1, False)
if six.PY3:
self.assertEqual(d1 < d1, False)
self.assertEqual(d1 <= d1, True)
self.assertEqual(d1 >= d1, True)
self.assertEqual(d1 > d1, False)

self.assertEqual(d2 == d1, False)
self.assertEqual(d2 != d1, True)

self.assertEqual(d2 < d1, False)
self.assertEqual(d2 <= d1, False)
self.assertEqual(d2 >= d1, True)
self.assertEqual(d2 > d1, True)

self.assertRaises(TypeError, lambda: d1 < None)
self.assertRaises(TypeError, lambda: d1 < System.Guid())

# ClassTest does not implement IComparable
c1 = ClassTest()
c2 = ClassTest()
self.assertRaises(TypeError, lambda: c1 < c2)
if six.PY3:
self.assertEqual(d2 < d1, False)
self.assertEqual(d2 <= d1, False)
self.assertEqual(d2 >= d1, True)
self.assertEqual(d2 > d1, True)

if six.PY3:
self.assertRaises(TypeError, lambda: d1 < None)
self.assertRaises(TypeError, lambda: d1 < System.Guid())

if six.PY3:
# ClassTest does not implement IComparable
c1 = ClassTest()
c2 = ClassTest()
self.assertRaises(TypeError, lambda: c1 < c2)


class ClassicClass:
Expand Down