Skip to content

Remove printing if Decref is called with NULL. Rename Decref/Incref to XDecref/XIncref #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
den-run-ai merged 4 commits into from
Oct 29, 2016
Merged

Remove printing if Decref is called with NULL. Rename Decref/Incref to XDecref/XIncref #275

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a3fc9e
Do not call Decref if self.repr is still IntPtr.Zero
Oct 19, 2016
d43d846
Same self.repr null check in ConstructorBinding.tp_dealloc
Oct 20, 2016
33437e7
Rename Runtime.Incref/Decref to XIncref/XDecref to signal that they c…
Oct 27, 2016
5181ef3
Add missing changes for Python 2
Oct 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Same self.repr null check in ConstructorBinding.tp_dealloc
  • Loading branch information
abessen committed Oct 20, 2016
commit d43d846cd957ed8561fc781fa34df183270da6c1
3 changes: 2 additions & 1 deletion src/runtime/constructorbinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ public static IntPtr tp_repr(IntPtr ob)
public static new void tp_dealloc(IntPtr ob)
{
ConstructorBinding self = (ConstructorBinding)GetManagedObject(ob);
Runtime.Decref(self.repr);
if (self.repr != IntPtr.Zero)
Runtime.Decref(self.repr);
Runtime.Decref(self.pyTypeHndl);
ExtensionType.FinalizeObject(self);
}
Expand Down