Skip to content

Silence compile-time warnings #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 1 commit into from
May 12, 2026
Merged

Silence compile-time warnings #2725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/embed_tests/Events.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ public ClassWithEventHandler()
this.arr = new int[800];
}

// Reference LeakEvent to silence warning
protected virtual void OnLeakEvent(EventArgs e)
{
LeakEvent?.Invoke(this, e);
}

~ClassWithEventHandler()
{
Interlocked.Decrement(ref alive);
Expand Down
2 changes: 2 additions & 0 deletions src/runtime/PythonTypes/PyFloat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,7 @@ public static PyFloat AsFloat(PyObject value)
public double ToDouble() => Runtime.PyFloat_AsDouble(obj);

public override TypeCode GetTypeCode() => TypeCode.Double;

public override int GetHashCode() => base.GetHashCode();
}
}
2 changes: 2 additions & 0 deletions src/runtime/PythonTypes/PyInt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,5 +232,7 @@ public string ToString(string format, IFormatProvider formatProvider)
}

public override TypeCode GetTypeCode() => TypeCode.Int64;

public override int GetHashCode() => base.GetHashCode();
}
}
2 changes: 1 addition & 1 deletion src/runtime/Util/ReflectionPolyfills.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public static AssemblyBuilder DefineDynamicAssembly(this AppDomain _, AssemblyNa

public static Type CreateType(this TypeBuilder typeBuilder)
{
return typeBuilder.CreateTypeInfo();
return typeBuilder.CreateTypeInfo()!;
}

public static T GetCustomAttribute<T>(this Type type) where T: Attribute
Expand Down
Loading