Alternative attempt at fixing memleak by being explicit about copies#2722
Draft
filmor wants to merge 5 commits into
Draft
Alternative attempt at fixing memleak by being explicit about copies#2722filmor wants to merge 5 commits into
filmor wants to merge 5 commits into
Conversation
lostmsu
reviewed
May 11, 2026
| Finalizer.Instance.ThrottledCollect(); | ||
| } | ||
|
|
||
| public PyObject Copy() => new(this); |
Member
There was a problem hiding this comment.
The name of this function is too generic and therefore misleading
Member
Author
There was a problem hiding this comment.
How is it misleading? This is exactly what it does (at least in Python terms). The current behaviour, being able to freely pass the object around, is the misleading thing IMO.
Member
There was a problem hiding this comment.
It does not make a copy of an object. It makes a separate living reference to it.
The slot initialisation walks from the most derived type up its inheritance hierarchy. If a type specifies a `tp_clear` (or any other slot) and its base type does as well, the (later) base type handling will overwrite the previously written version. We now limit ourselves to methods that are declared on the most current level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.