Skip to content

2574 StackOverflow Exception On Super Method Call Fix #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmadsen-ks wants to merge 4 commits into
base: master
Choose a base branch
from
+88 −24
Open

2574 StackOverflow Exception On Super Method Call Fix #2628

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
883576b
Fixed issue calling multiple levels of derived classes with some defi…
rmadsen-ks Oct 8, 2025
23df0e8
Added fix for calling virtual method on baseclass which is not defined.
rmadsen-ks Oct 9, 2025
9831bb9
minor cleanup
rmadsen-ks Oct 14, 2025
3ba30c4
Merge branch 'master' into 2574-StackOverFlowExceptionOnSuperMethodCa…
filmor Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor cleanup
  • Loading branch information
@rmadsen-ks @filmor
rmadsen-ks authored and filmor committed Mar 25, 2026
commit 9831bb91632d8e762eb8181b8678686271e6b213
6 changes: 2 additions & 4 deletions src/runtime/Types/ClassDerived.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ internal static Type CreateDerivedType(string name,


// override the virtual method to call out to the python method, if there is one.
AddVirtualMethod(method, baseType, typeBuilder, isDeclared);
AddVirtualMethod(method, typeBuilder);
}

// Add any additional methods and properties explicitly exposed from Python.
Expand Down Expand Up @@ -384,10 +384,8 @@ private static void AddConstructor(ConstructorInfo ctor, Type baseType, TypeBuil
/// and calls it, otherwise fall back to the base class method.
/// </summary>
/// <param name="method">virtual method to be overridden</param>
/// <param name="baseType">Python callable object</param>
/// <param name="typeBuilder">TypeBuilder for the new type the method is to be added to</param>
/// <param name="isDeclared"></param>
private static void AddVirtualMethod(MethodInfo method, Type baseType, TypeBuilder typeBuilder, bool isDeclared)
private static void AddVirtualMethod(MethodInfo method, TypeBuilder typeBuilder)
{
ParameterInfo[] parameters = method.GetParameters();
Type[] parameterTypes = (from param in parameters select param.ParameterType).ToArray();
Expand Down
Loading