Skip to content

Implement coerce logic for net method binding #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
generalloki wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement coerce logic for net method binding #2590

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf01b18
MethodBinderEvents.CoerceBind
generalloki May 6, 2025
16e4aaf
Update MethodBinder.cs
generalloki May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
MethodBinderEvents.CoerceBind
  • Loading branch information
@generalloki @filmor
generalloki authored and filmor committed Dec 8, 2025
commit cf01b188810befe0355501433cbe4c196d528375
28 changes: 26 additions & 2 deletions src/runtime/MethodBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
namespace Python.Runtime
{
using MaybeMethodBase = MaybeMethodBase<MethodBase>;

public delegate void MethodBinderCoerceBindDelegate(
Dictionary<string, PyObject> arguments,
MethodBase[] methods,
ref MethodBase? foundBinding);

/// <summary>
/// A MethodBinder encapsulates information about a (possibly overloaded)
/// managed method, and is responsible for selecting the right method given
Expand Down Expand Up @@ -516,7 +522,7 @@ public MismatchedMethod(Exception exception, MethodBase mb)
}
}

return new Binding(mi, target, margs, outs);
return CoerceResult(new Binding(mi, target, margs, outs));
}
else if (matchGenerics && isGeneric)
{
Expand All @@ -528,7 +534,7 @@ public MismatchedMethod(Exception exception, MethodBase mb)
MethodInfo[] overloads = MatchParameters(methods, types);
if (overloads.Length != 0)
{
return Bind(inst, args, kwargDict, overloads, matchGenerics: false);
return CoerceResult(Bind(inst, args, kwargDict, overloads, matchGenerics: false));
}
}
if (mismatchedMethods.Count > 0)
Expand All @@ -537,6 +543,19 @@ public MismatchedMethod(Exception exception, MethodBase mb)
Exceptions.SetError(aggregateException);
}
return null;

Binding? CoerceResult(Binding? binding)
{
if (binding is not null)
{
var foundMethod = binding.info;
MethodBinderEvents.CoerceBind?.Invoke(kwargDict, methods, ref foundMethod);
if (foundMethod is null)
return null;
}

return binding;
}
}

static AggregateException GetAggregateException(IEnumerable<MismatchedMethod> mismatchedMethods)
Expand Down Expand Up @@ -1068,4 +1087,9 @@ static internal class ParameterInfoExtensions
}
}
}

public static class MethodBinderEvents
{
public static MethodBinderCoerceBindDelegate? CoerceBind;
}
}