Skip to content

Improve loader robustness #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sefgit wants to merge 3 commits into from
Closed

Improve loader robustness #2303

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca105f9
Improve loader robustness
sefgit Dec 26, 2023
2e81a55
as required to submit PR
sefgit Dec 26, 2023
a57b8de
Use Debug instead of Console.Error
sefgit Dec 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use Debug instead of Console.Error 
updated to use Debug
  • Loading branch information
@sefgit
sefgit committed Dec 29, 2023
commit a57b8de4e0fb30166eee292941a8f427a530cd66
8 changes: 4 additions & 4 deletions src/runtime/AssemblyManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ internal static Type[] GetTypes(Assembly a)
// Return all types that were successfully loaded
foreach (var item in exc.LoaderExceptions)
{
System.Console.Error.WriteLine("[pythonnet] {0}", item.Message);
Debug.WriteLine("[pythonnet] {0}", item.Message);
}
return exc.Types.Where(x => x != null && IsExported(x)).ToArray();
}
Expand All @@ -429,7 +429,7 @@ internal static Type[] GetTypes(Assembly a)
}
catch (FileNotFoundException)
{
System.Console.Error.WriteLine("[pythonnet] {0} File not found", a.GetName());
Debug.WriteLine("[pythonnet] {0} File not found", a.GetName());
return new Type[0];
}
catch (System.TypeLoadException e)
Expand All @@ -442,15 +442,15 @@ internal static Type[] GetTypes(Assembly a)
{
foreach (var item in exc.LoaderExceptions)
{
System.Console.Error.WriteLine("[pythonnet] {0}", item.Message);
Debug.WriteLine("[pythonnet] {0}", item.Message);
}
// Return all types that were successfully loaded
return exc.Types.Where(x => x != null && IsExported(x)).ToArray();
}
}
catch (Exception e) // System.TypeLoadException
{
System.Console.Error.WriteLine("[pythonnet] {0} {1}", a.GetName(), e);
Debug.WriteLine("[pythonnet] {0} {1}", a.GetName(), e);
return new Type[0];
}

Expand Down