Skip to content

Skip garbage collection on process shutdown #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filmor wants to merge 6 commits into from
Closed

Skip garbage collection on process shutdown #2245

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f5a850
Skip garbage collection on process shutdown
filmor Sep 23, 2023
85f74bb
Shut down by default without allowing reload, throw on attempt
filmor Sep 23, 2023
8e4a197
Refactor embed tests to use common fixture
filmor Sep 23, 2023
df53d68
Fix accidental move of Reset call
filmor Sep 23, 2023
4fe3757
Fix refactored tests
filmor Sep 23, 2023
7fc2e1d
Only recover stashed data if the domain is actually changed
filmor Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Skip garbage collection on process shutdown
  • Loading branch information
@filmor
filmor committed Sep 23, 2023
commit 8f5a8503d16cc0703e6fef189fd26e9d33b55019
22 changes: 14 additions & 8 deletions src/runtime/Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,20 +294,26 @@ internal static void Shutdown()
DisposeLazyObject(hexCallable);
PyObjectConversions.Reset();

PyGC_Collect();
bool everythingSeemsCollected = TryCollectingGarbage(MaxCollectRetriesOnShutdown,
forceBreakLoops: true);
Debug.Assert(everythingSeemsCollected);
if (!ProcessIsTerminating)
{
PyGC_Collect();
bool everythingSeemsCollected = TryCollectingGarbage(MaxCollectRetriesOnShutdown,
forceBreakLoops: true);
Debug.Assert(everythingSeemsCollected);
}

ResetPyMembers();
Finalizer.Shutdown();
InternString.Shutdown();

ResetPyMembers();

if (!HostedInPython)
{
GC.Collect();
GC.WaitForPendingFinalizers();
if (!ProcessIsTerminating)
{
GC.Collect();
GC.WaitForPendingFinalizers();
}

PyGILState_Release(state);
// Then release the GIL for good, if there is somehting to release
// Use the unchecked version as the checked version calls `abort()`
Expand Down