Skip to content

Use msbuild tools from PATH if available #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonyroberts merged 1 commit into from
Jun 23, 2016
Merged

Use msbuild tools from PATH if available #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use msbuild tools from PATH 
While _find_msbuild_tool searches in the registry to find the given
build tool, it doesn't check if it's already in PATH.

If one uses a developer command prompt to build, all necessary tools are
in PATH.

Fixes #207 for me
  • Loading branch information
@rnestler
rnestler committed Apr 20, 2016
commit 35e3b28ca193cb3248b4e0d6b437e03dd4e60e0e
5 changes: 5 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from distutils.command.install_lib import install_lib
from distutils.command.install_data import install_data
from distutils.sysconfig import get_config_var
from distutils.spawn import find_executable
from distutils import log
from platform import architecture
from subprocess import Popen, CalledProcessError, PIPE, check_call
Expand All @@ -23,6 +24,10 @@

def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False):
"""Return full path to one of the microsoft build tools"""
path = find_executable(tool)
Copy link
Copy Markdown
Contributor

@tonyroberts tonyroberts Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be below the docstring

Copy link
Copy Markdown
Contributor Author

@rnestler rnestler Apr 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my god how did that happen 😮 Silly me.

if path:
return path

try:
import _winreg
except ImportError:
Expand Down