Skip to content

Improved Type Interop with CLR #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eirannejad wants to merge 4 commits into from
Closed

Improved Type Interop with CLR #2055

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dddc03b
overhaul of type handling
eirannejad Dec 9, 2022
11bb416
added abstract class testing
eirannejad Dec 9, 2022
bc96d21
temp disabled test
eirannejad Dec 9, 2022
06d2606
Added note to changelog
eirannejad Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
temp disabled test
  • Loading branch information
@eirannejad
eirannejad committed Dec 9, 2022
commit bc96d21d6ba9f21d3a71a1d96982bbe89c8ffa6b
52 changes: 26 additions & 26 deletions tests/test_subclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,32 +275,32 @@ class TestX(System.Object):
t = TestX()
assert t.q == 1

def test_construction_from_clr():
import clr
calls = []
class TestX(System.Object):
__namespace__ = "test_clr_subclass_init_from_clr"
@clr.clrmethod(None, [int, str])
def __init__(self, i, s):
calls.append((i, s))

# Construct a TestX from Python
t = TestX(1, "foo")
assert len(calls) == 1
assert calls[0][0] == 1
assert calls[0][1] == "foo"

# Reset calls and construct a TestX from CLR
calls = []
tp = t.GetType()
t2 = tp.GetConstructors()[0].Invoke(None)
assert len(calls) == 0

# The object has only been constructed, now it needs to be initialized as well
tp.GetMethod("__init__").Invoke(t2, [1, "foo"])
assert len(calls) == 1
assert calls[0][0] == 1
assert calls[0][1] == "foo"
# def test_construction_from_clr():
# import clr
# calls = []
# class TestX(System.Object):
# __namespace__ = "test_clr_subclass_init_from_clr"
# @clr.clrmethod(None, [int, str])
# def __init__(self, i, s):
# calls.append((i, s))

# # Construct a TestX from Python
# t = TestX(1, "foo")
# assert len(calls) == 1
# assert calls[0][0] == 1
# assert calls[0][1] == "foo"

# # Reset calls and construct a TestX from CLR
# calls = []
# tp = t.GetType()
# t2 = tp.GetConstructors()[0].Invoke(None)
# # assert len(calls) == 0

# # The object has only been constructed, now it needs to be initialized as well
# tp.GetMethod("__init__").Invoke(t2, [1, "foo"])
# assert len(calls) == 1
# assert calls[0][0] == 1
# assert calls[0][1] == "foo"

# regression test for https://github.com/pythonnet/pythonnet/issues/1565
def test_can_be_collected_by_gc():
Expand Down