Skip to content

Fixed use of the process handle after Process instance is garbage collected #1940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 1 commit into from
Sep 16, 2022
Merged

Fixed use of the process handle after Process instance is garbage collected #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixed use of the process handle after Process instance goes out of scope 
fixes #1939
  • Loading branch information
@lostmsu
lostmsu committed Sep 15, 2022
commit 86b9811f74b5f888569d67b3bbd69858332d3737
6 changes: 3 additions & 3 deletions src/runtime/Native/LibraryLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,17 +137,17 @@ public IntPtr GetFunction(IntPtr hModule, string procedureName)

static IntPtr[] GetAllModules()
{
var self = Process.GetCurrentProcess().Handle;
using var self = Process.GetCurrentProcess();

uint bytes = 0;
var result = new IntPtr[0];
if (!EnumProcessModules(self, result, bytes, out var needsBytes))
if (!EnumProcessModules(self.Handle, result, bytes, out var needsBytes))
throw new Win32Exception();
while (bytes < needsBytes)
{
bytes = needsBytes;
result = new IntPtr[bytes / IntPtr.Size];
if (!EnumProcessModules(self, result, bytes, out needsBytes))
if (!EnumProcessModules(self.Handle, result, bytes, out needsBytes))
throw new Win32Exception();
}
return result.Take((int)(needsBytes / IntPtr.Size)).ToArray();
Expand Down