Skip to content

Best effort serialization #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BadSingleton wants to merge 5 commits into from
Closed

Best effort serialization #1892

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61e1ede
Last line of defense, best effort serialization
BadSingleton Jun 23, 2022
fc1044a
Add nested class support
BadSingleton Jun 30, 2022
ff550c6
fixup! Add nested class support
BadSingleton Jun 30, 2022
2caa2e5
Workaround for mono attribute bug
BadSingleton Jul 6, 2022
0a81466
fixup! Workaround for mono attribute bug
BadSingleton Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Add nested class support
  • Loading branch information
@BadSingleton
BadSingleton committed Jul 29, 2022
commit ff550c67fef4656d1532dcda1d55ed8db53dbcbf
2 changes: 1 addition & 1 deletion src/runtime/StateSerialization/RuntimeData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public void GetObjectData(object obj, SerializationInfo info, StreamingContext c

MaybeType type = obj.GetType();

if (type.Value.CustomAttributes.Any((attr) => attr.AttributeType == typeof(NonSerializedAttribute)))
if (type.Value.CustomAttributes.Any((attr) => attr.AttributeType == typeof(PyNet_NotSerializedAttribute)))
{
// Don't serialize a _NotSerialized. Serialize the base type, and deserialize as a _NotSerialized
type = type.Value.BaseType;
Expand Down