Skip to content

Temporary fix method binder for out parameters #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmsu merged 7 commits into from
Jan 14, 2022
Merged

Temporary fix method binder for out parameters #1672

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a13d3c9
temp fixed method binder for out params
eirannejad Jan 13, 2022
21ea5f8
Fixed C# code styling
eirannejad Jan 14, 2022
f61faa3
added contributer
eirannejad Jan 14, 2022
6c5e565
updated changelog
eirannejad Jan 14, 2022
1964a49
modified existing method out parameter tests
eirannejad Jan 14, 2022
f07cbb9
Revert "modified existing method out parameter tests"
eirannejad Jan 14, 2022
961bd19
now testing out-parameters w/o explicitly passing values
eirannejad Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/runtime/MethodBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,9 @@ static BorrowedReference HandleParamsArray(BorrowedReference args, int arrayStar
margs[paramIndex] = defaultArgList[paramIndex - pyArgCount];
}

if (parameter.ParameterType.IsByRef)
Comment thread
eirannejad marked this conversation as resolved.
outs++;

continue;
}

Expand Down Expand Up @@ -817,6 +820,9 @@ static bool MatchesArgumentCount(int positionalArgumentCount, ParameterInfo[] pa
defaultArgList.Add(parameters[v].GetDefaultValue());
defaultsNeeded++;
}
else if (parameters[v].IsOut) {
defaultArgList.Add(null);
}
else if (!paramsArray)
{
match = false;
Expand Down