Skip to content

Do not clean tpHandle in ClassBase.tp_clear - it might be used in tp_dealloc #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmsu merged 3 commits into from
Sep 23, 2021
Merged

Do not clean tpHandle in ClassBase.tp_clear - it might be used in tp_dealloc #1566

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb4a3d8
added a few debug guards
lostmsu Sep 23, 2021
d975d5f
added regression test for https://github.com/pythonnet/pythonnet/issu…
lostmsu Sep 23, 2021
2dd5ee6
Do not clean tpHandle in ClassBase.tp_clear - it might be used in tp_…
lostmsu Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added regression test for #1565 (unable to gc collect an instance of … 
…python derived type)
  • Loading branch information
@lostmsu
lostmsu committed Sep 23, 2021
commit d975d5f03757c7821811be79e598b00d10bed393
16 changes: 16 additions & 0 deletions tests/test_subclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,3 +290,19 @@ def __init__(self, i, s):
assert len(calls) == 1
assert calls[0][0] == 1
assert calls[0][1] == "foo"

# regression test for https://github.com/pythonnet/pythonnet/issues/1565
def test_can_be_collected_by_gc():
from Python.Test import BaseClass

class Derived(BaseClass):
__namespace__ = 'test_can_be_collected_by_gc'

inst = Derived()
cycle = [inst]
del inst
cycle.append(cycle)
del cycle

import gc
gc.collect()