Skip to content

[WIP] Add ability to create module from C# #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmsu merged 7 commits into from
Jul 29, 2021
Merged

[WIP] Add ability to create module from C# #1447

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ea87103
Add ability to create module from C#
slide Apr 21, 2021
807252a
Merge branch 'master' of https://github.com/pythonnet/pythonnet into …
slide Apr 26, 2021
bf679dc
Move to PyModule and add test
slide Apr 26, 2021
a5218ed
Merge remote-tracking branch 'origin/master' into addmodule
slide Jul 27, 2021
f872b3d
Changes based on feedback
slide Jul 27, 2021
d4a32ed
Fix some of the feedback
slide Jul 28, 2021
ab0cedb
More feedback fixup
slide Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some of the feedback
  • Loading branch information
@slide
slide committed Jul 28, 2021
commit d4a32ed37dcc36d9ce9a9b9b5a8f4e502be9af26
9 changes: 7 additions & 2 deletions src/runtime/pymodule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,19 @@ public static bool IsInSysModules(string name)

public static PyModule Create(string name, string filename=null)
{
if(string.IsNullOrWhiteSpace(name))
{
throw new ArgumentNullException(nameof(name));
}

NewReference op = Runtime.PyModule_New(name);
Comment thread
slide marked this conversation as resolved.
PythonException.ThrowIfIsNull(op);

if (filename != null)
{
BorrowedReference globals = Runtime.PyModule_GetDict(new BorrowedReference(op.DangerousGetAddress()));
BorrowedReference globals = Runtime.PyModule_GetDict(op);
PythonException.ThrowIfIsNull(globals);
int rc = Runtime.PyDict_SetItemString(globals, "__file__", new BorrowedReference(filename.ToPython().Handle));
int rc = Runtime.PyDict_SetItemString(globals, "__file__", filename.ToPython().Reference);
PythonException.ThrowIfIsNotZero(rc);
}

Expand Down