Skip to content

Prevent stack overflow when an encoder is registered from Python #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmsu merged 3 commits into from
Mar 31, 2021
Merged

Prevent stack overflow when an encoder is registered from Python #1429

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aedcb88
added regression test for https://github.com/pythonnet/pythonnet/issu…
lostmsu Mar 30, 2021
ae3477d
disabled ability to register encoders for `System.Type`
lostmsu Mar 30, 2021
0d33a90
disabled PythonRegisteredDecoder_NoStackOverflowOnSystemType test due…
lostmsu Mar 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
disabled PythonRegisteredDecoder_NoStackOverflowOnSystemType test due… 
… to known issue with custom codes + engine restarts

#1256
  • Loading branch information
@lostmsu
lostmsu committed Mar 31, 2021
commit 0d33a9074b62b33457d577c9df0240f0a33f0a9c
1 change: 1 addition & 0 deletions src/embed_tests/Codecs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ public void IterableDecoderTest()
}

// regression for https://github.com/pythonnet/pythonnet/issues/1427
[Ignore("https://github.com/pythonnet/pythonnet/issues/1256")]
[Test]
public void PythonRegisteredDecoder_NoStackOverflowOnSystemType()
{
Expand Down