Skip to content

Fix exception refcnt #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BadSingleton wants to merge 6 commits into from
Closed

Fix exception refcnt #1402

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee30c94
Fix a ref count issue in PythonException
BadSingleton Feb 11, 2021
480a549
Fixes a leak in ExceptionClassObject
BadSingleton Feb 26, 2021
5ea9c3c
Code review fixes
BadSingleton Mar 4, 2021
891ad8c
code review fixes
BadSingleton Mar 5, 2021
d180f2a
kick the build
BadSingleton Mar 8, 2021
47290ee
kick the build, again
BadSingleton Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review fixes
  • Loading branch information
@BadSingleton
BadSingleton committed Mar 5, 2021
commit 891ad8c93afba36499b777b5140a388cb70e9d6a
7 changes: 5 additions & 2 deletions src/runtime/exceptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,11 @@ internal static Exception ToException(IntPtr ob)
static void ClearOffsetHelper(IntPtr ob, int offset)
{
var field = Marshal.ReadIntPtr(ob, offset);
Runtime.XDecref(field);
Marshal.WriteIntPtr(ob, offset, IntPtr.Zero);
if (field != IntPtr.Zero)
{
Marshal.WriteIntPtr(ob, offset, IntPtr.Zero);
Runtime.XDecref(field);
}
}
Comment thread
lostmsu marked this conversation as resolved.

// As seen in exceptions.c, every derived type must also clean the base.
Expand Down