(WIP) import hook in the pytohn module

pythonnet · filmor · Jun 18, 2021 · Jan 15, 2021 · Jan 15, 2021 · Jan 15, 2021
commit be8136448e1220f2a3ea93f7243c2f4a8eaa6237
diff --git a/pythonnet/util/__init__.py b/pythonnet/util/__init__.py
@@ -1 +1 @@
-from .find_libpython import find_libpython
+from ..find_libpython import find_libpython
diff --git a/pythonnet/util/import_hook.py b/pythonnet/util/import_hook.py
@@ -0,0 +1,33 @@
+import importlib.abc
+import sys
+
+class DotNetLoader(importlib.abc.Loader):
+
+    def __init__(self):
+        super(DotNetLoader, self).__init__()
+
+    @classmethod
+    def exec_module(klass, mod):
+        # This method needs to exist.
+        pass
+
+    @classmethod
+    def create_module(klass, spec):
+        import clr
+        return clr._LoadClrModule(spec)
+
+class DotNetFinder(importlib.abc.MetaPathFinder):
+
+    def __init__(self):
+        super(DotNetFinder, self).__init__()
+
+    @classmethod
+    def find_spec(klass, fullname, paths=None, target=None):
+        import clr
+        if (hasattr(clr, '_availableNamespaces') and fullname in clr._availableNamespaces):
+            return importlib.machinery.ModuleSpec(fullname, DotNetLoader(), is_package=True)
+        return None
+
+
+def init_import_hook():
+    sys.meta_path.append(DotNetFinder())
diff --git a/src/runtime/importhook.cs b/src/runtime/importhook.cs
@@ -69,7 +69,7 @@ internal static unsafe void Initialize()
 
             // Add/create the MetaPathLoader
             SetupNamespaceTracking();
-            PythonEngine.Exec(LoaderCode);
+            PythonEngine.Exec("import pythonnet.util.import_hook;pythonnet.util.import_hook.init_import_hook()");
         }
 
 
@@ -225,7 +225,7 @@ public static unsafe NewReference GetCLRModule()
         /// <summary>
         /// The hook to import a CLR module into Python
         /// </summary>
-        public static ModuleObject __import__(string modname)
+        public static ModuleObject Import(string modname)
         {
             // Traverse the qualified module name to get the named module. 
             // Note that if

diff --git a/src/runtime/moduleobject.cs b/src/runtime/moduleobject.cs
@@ -598,7 +598,7 @@ public static PyObject _LoadClrModule(PyObject spec)
             ModuleObject mod = null;
             using (var modname = spec.GetAttr("name"))
             {
-                mod = ImportHook.__import__(modname.ToString());
+                mod = ImportHook.Import(modname.ToString());
             }
             // We can't return directly a ModuleObject, because the tpHandle is
             // not set, but we can return a PyObject.

diff --git a/src/runtime/runtime.cs b/src/runtime/runtime.cs
@@ -153,6 +153,16 @@ internal static void Initialize(bool initSigs = false, ShutdownMode mode = Shutd
             ClassDerivedObject.Reset();
             TypeManager.Initialize();
 
+            // Need to add the runtime directory to sys.path so that we
+            // can find built-in assemblies like System.Data, et. al.
+            string rtdir = RuntimeEnvironment.GetRuntimeDirectory();
+            IntPtr path = PySys_GetObject("path").DangerousGetAddress();
+            IntPtr item = PyString_FromString(rtdir);
+            if (PySequence_Contains(path, item) == 0)
+            {
+                PyList_Append(new BorrowedReference(path), item);
+            }
+            XDecref(item);
             // Initialize modules that depend on the runtime class.
             AssemblyManager.Initialize();
             OperatorMethod.Initialize();
@@ -167,16 +177,6 @@ internal static void Initialize(bool initSigs = false, ShutdownMode mode = Shutd
             }
             Exceptions.Initialize();
 
-            // Need to add the runtime directory to sys.path so that we
-            // can find built-in assemblies like System.Data, et. al.
-            string rtdir = RuntimeEnvironment.GetRuntimeDirectory();
-            IntPtr path = PySys_GetObject("path").DangerousGetAddress();
-            IntPtr item = PyString_FromString(rtdir);
-            if (PySequence_Contains(path, item) == 0)
-            {
-                PyList_Append(new BorrowedReference(path), item);
-            }
-            XDecref(item);
             AssemblyManager.UpdatePath();
         }
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		from .find_libpython import find_libpython
		from ..find_libpython import find_libpython