Skip to content

Support comparison operators #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmsu merged 12 commits into from
Jan 12, 2021
Merged

Support comparison operators #1347

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9a8cb96
Add comparison operators
christabella Dec 29, 2020
bcbace3
Add tests for logical (bool) comparison operators
christabella Dec 29, 2020
31f3ed1
Finish comparison operator impl and add tests
christabella Jan 6, 2021
ae7e774
Add eq and ineq operators, disallow reverse for comp
christabella Jan 7, 2021
5685727
Minor formatting (whitespace, ordering)
christabella Jan 7, 2021
03a73c0
Minor: use `out var` instead of declaring separately.
christabella Jan 7, 2021
67928e1
Implement .Equals and .GetHashCode to fix warning
christabella Jan 7, 2021
6a64678
Style (TryGetValue), formatting, and minor changes
christabella Jan 8, 2021
9dd9162
Use a separate map for comparison operators
christabella Jan 8, 2021
a8c6591
Add tuple comparison operator tests (2/6)
christabella Jan 11, 2021
6d4dec7
Add reverse case for tuple comparison op test
christabella Jan 11, 2021
7a2b5e2
Simplify PyObj casting, logic of if blocks.
christabella Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor: use out var instead of declaring separately.
  • Loading branch information
@christabella
christabella committed Jan 12, 2021
commit 03a73c08f5f1e70cd9ef1ce5d8ae7a2e47e92df7
3 changes: 1 addition & 2 deletions src/runtime/classmanager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,8 +557,7 @@ private static ClassInfo GetClassInfo(Type type)
{
string pyName = OperatorMethod.GetPyMethodName(name);
string pyNameReverse = OperatorMethod.ReversePyMethodName(pyName);
MethodInfo[] forwardMethods, reverseMethods;
OperatorMethod.FilterMethods(mlist, out forwardMethods, out reverseMethods);
OperatorMethod.FilterMethods(mlist, out var forwardMethods, out var reverseMethods);
// Only methods where the left operand is the declaring type.
if (forwardMethods.Length > 0)
ci.members[pyName] = new MethodObject(type, name, forwardMethods);
Expand Down