Skip to content

Codecs: customize set of Py<->C# conversions via PyObjectConversions #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmsu merged 17 commits into from
Feb 26, 2020
Merged

Codecs: customize set of Py<->C# conversions via PyObjectConversions #1022

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
28143d5
enable expanding set of marshaling conversions via PyObjectConversions
lostmsu Sep 12, 2019
6eca169
fixed ConversionsObject test failing due to sequence to array convers…
lostmsu Jan 16, 2020
97e33c7
attempt to fix CI build issue with ValueTuple under Mono
lostmsu Jan 16, 2020
449338f
added RefereneAssemblies package reference to fix CI build
lostmsu Jan 30, 2020
39b2347
marked the new codecs API as unstable
lostmsu Feb 1, 2020
daa2901
attempt to fix PyScopeTest.TestThread() reading stale value from res …
lostmsu Feb 1, 2020
e8e3b4b
Merge branch 'master' into PR/Codecs
lostmsu Feb 13, 2020
8818610
Merge branch 'master' into PR/Codecs
filmor Feb 13, 2020
82f6b99
Merge branch 'master' into PR/Codecs
lostmsu Feb 21, 2020
ec98209
fixed bad IncRef after PyTuple_New
lostmsu Feb 21, 2020
50a3822
corrected reference counting in Codecs
lostmsu Feb 21, 2020
2e19f2c
don't dispose encoded object in case codec keeps a cache of them
lostmsu Feb 21, 2020
44bfec2
Merge branch 'master' into PR/Codecs
filmor Feb 23, 2020
399ae54
do not dispose object, that might have been just decoded succesfully,…
lostmsu Feb 23, 2020
e2d3333
remove incref for tuple fields, as Converter.ToPython is supposed to …
lostmsu Feb 23, 2020
5619fb9
Merge branch 'master' into PR/Codecs
filmor Feb 25, 2020
41de69d
Merge branch 'master' into PR/Codecs
lostmsu Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not dispose object, that might have been just decoded succesfully,… 
… as the decoded object might store a reference to the original PyObject
  • Loading branch information
@lostmsu
lostmsu committed Feb 23, 2020
commit 399ae545c9c6a4ab0a0f1713e41eb1c41c889ca4
13 changes: 8 additions & 5 deletions src/runtime/converterextensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,13 +137,16 @@ static Converter.TryConvertFromPythonDelegate GetDecoder(IntPtr sourceType, Type

bool TryDecode(IntPtr pyHandle, out object result)
{
using (var pyObj = new PyObject(Runtime.SelfIncRef(pyHandle)))
var pyObj = new PyObject(Runtime.SelfIncRef(pyHandle));
var @params = new object[] { pyObj, null };
bool success = (bool)decode.Invoke(decoder, @params);
if (!success)
{
var @params = new object[] { pyObj, null };
bool success = (bool)decode.Invoke(decoder, @params);
result = @params[1];
return success;
pyObj.Dispose();
}

result = @params[1];
return success;
}

return TryDecode;
Expand Down