why msbuild added to %path% in bld.bat for conda build? #438

Activity

1. filmor commented on Mar 23, 2017

   

   filmor

   on Mar 23, 2017

   Member

   More actions

   Nice description 😜

   I had problems in the past with using the script element in the conda recipe, which can in theory look like

   script: "python setup.py install",
   

   So: "yes".

   I'm not sure, why $PATH is overridden in there, though.
2. filmor

   closed this as completedon Mar 23, 2017
3. den-run-ai

   changed the title [-]bld.bat required for conda build?[/-] [+]why msbuild added to %path% in bld.bat for conda build?[/+] on Mar 23, 2017
4. den-run-ai commented on Mar 23, 2017

   

   den-run-ai

   on Mar 23, 2017

   ContributorAuthor

   More actions

   @filmor I update the title: why msbuild added to %path% in bld.bat for conda build?
5. den-run-ai

   reopened this on Mar 23, 2017
6. vmuriart commented on Mar 23, 2017

   

   vmuriart

   on Mar 23, 2017

   Contributor

   More actions

   I think msbuild was added there since alot of packages have issues detecting the presence of msbuild. The recipe was copied from another example probably that used it. In our case its most likely not needed, though I havent tested it yet.
7. vmuriart commented on Mar 23, 2017

   

   vmuriart

   on Mar 23, 2017

   Contributor

   More actions

   bah. build fails without path. Atleast in AppVeyor it looks like the wrong msbuild is being selected.
8. den-run-ai commented on Mar 24, 2017

   

   den-run-ai

   on Mar 24, 2017

   ContributorAuthor

   More actions

   @vmuriart so we can close this issue?
9. vmuriart commented on Mar 24, 2017

   

   vmuriart

   on Mar 24, 2017

   Contributor

   More actions

   Sure
10. den-run-ai

    closed this as completedon Mar 24, 2017