Skip to content

Add scikit-learn#153

Merged
Carreau merged 1 commit intopython3statement:masterfrom
rth:scikit-learn
Sep 18, 2018
Merged

Add scikit-learn#153
Carreau merged 1 commit intopython3statement:masterfrom
rth:scikit-learn

Conversation

@rth
Copy link
Copy Markdown
Contributor

@rth rth commented Sep 18, 2018

Scikit-learn 0.20 is the latest release to support Python 2.7 (see scikit-learn/scikit-learn#11115 for more details).

scikit-learn 0.20-rc1 was released a few weeks ago, with the final release planned in the coming days. Assuming an (optimistic) 6 month release schedule, this means that the first python 3 only version will happen 6 month from now. The dates are somewhat approximate, but I think it's good enough.

Comment thread site.js
@Carreau
Copy link
Copy Markdown
Member

Carreau commented Sep 18, 2018

Awesome !

Thanks !

Feel free to ping any of us when you transition, read the practicalities section to make sure to use python_requires correctly (to not break for Python 2 users, and feel free to ping here if you need a pair of eyes on the Pr that drop 2.7.

@Carreau Carreau merged commit aa3d1b0 into python3statement:master Sep 18, 2018
@rth rth deleted the scikit-learn branch September 18, 2018 12:15
@rth
Copy link
Copy Markdown
Contributor Author

rth commented Sep 18, 2018

Thanks a lot for the review and suggestions !

@takluyver
Copy link
Copy Markdown
Member

cc @amueller @GaelVaroquax @ogrisel @jnothman - we generally ask project maintainers to agree on signing this statement, even if the project's release schedule is compatible with it. Some projects (like Django) have made Python-3-only releases but chosen not to sign the statement.

In this case, scikit-learn already got added. Obviously we hope you'll leave it there - the statement is a more persuasive argument with more projects on board - but if you decide you'd rather not, please let us know.

@takluyver
Copy link
Copy Markdown
Member

Extra cc @GaelVaroquaux because I misspelled his handle above.

@amueller
Copy link
Copy Markdown

I think @rth is in a fine position to make the call ;) But for the record I think it's good to sign.
The estimate for the release timeline is a bit optimistic though ;)

@GaelVaroquaux
Copy link
Copy Markdown

+1 on what @amueller said. But it's fine to have a somewhat optimistic release timeline here.

@ogrisel
Copy link
Copy Markdown

ogrisel commented Sep 18, 2018

+1 as well.

@takluyver
Copy link
Copy Markdown
Member

Thanks everyone. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants