Skip to content

Improve log message when receiving an invalid or corrupt packet#998

Merged
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:rework_choked_message
Sep 23, 2021
Merged

Improve log message when receiving an invalid or corrupt packet#998
bdraco merged 1 commit into
python-zeroconf:masterfrom
bdraco:rework_choked_message

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Sep 23, 2021

  • The choked wording makes it seems like there is a problem in zeroconf when
    the usual case was an invalid packet send or corrupt wire data.

closes #993

- The choked wording makes it seems like there is a problem in zeroconf when
  the usual case was an invalid packet send or corrupt wire data.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #998 (eb84c8e) into master (7df7e4a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #998   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2505      2506    +1     
  Branches       409       409           
=========================================
+ Hits          2505      2506    +1     
Impacted Files Coverage Δ
zeroconf/_core.py 100.00% <100.00%> (ø)
zeroconf/_protocol/incoming.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df7e4a...eb84c8e. Read the comment docs.

@bdraco bdraco merged commit b637846 into python-zeroconf:master Sep 23, 2021
@bdraco bdraco deleted the rework_choked_message branch September 23, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple warn logs of "Choked at offset"

2 participants